[
https://issues.apache.org/jira/browse/MPIR-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928862#comment-17928862
]
ASF GitHub Bot commented on MPIR-478:
-------------------------------------
elharo commented on code in PR #97:
URL:
https://github.com/apache/maven-project-info-reports-plugin/pull/97#discussion_r1963958745
##########
src/main/java/org/apache/maven/report/projectinfo/TeamReport.java:
##########
@@ -226,10 +276,7 @@ private void renderTeamMember(Contributor member,
Map<String, Boolean> headersMa
Properties properties = member.getProperties();
String picUrl = properties.getProperty("picUrl");
if (picUrl == null || picUrl.isEmpty()) {
- picUrl = getGravatarUrl(member.getEmail());
- }
- if (picUrl == null || picUrl.isEmpty()) {
- picUrl = getSpacerGravatarUrl();
+ picUrl = getExternalAvatarUrl(member.getEmail());
Review Comment:
Looks like you can handle the IOException in this method. It doesn't need
tonescape this class. Just wrap lines 277 through 285 in a try-catch block. The
catch block can be empty or it can fill in a default image.
> describe use of gravatar.com for profiles in team report
> --------------------------------------------------------
>
> Key: MPIR-478
> URL: https://issues.apache.org/jira/browse/MPIR-478
> Project: Maven Project Info Reports Plugin
> Issue Type: Improvement
> Components: team
> Affects Versions: 3.8.0
> Reporter: Herve Boutemy
> Assignee: Slawomir Jaranowski
> Priority: Major
> Fix For: 3.9.0
>
>
> like MARTIFACT-83, to clarify privacy implications
> see
> https://github.com/apache/maven-project-info-reports-plugin/blob/master/src/main/java/org/apache/maven/report/projectinfo/TeamReport.java
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
