[ 
https://issues.apache.org/jira/browse/MPIR-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928679#comment-17928679
 ] 

ASF GitHub Bot commented on MPIR-478:
-------------------------------------

slawekjaranowski commented on code in PR #97:
URL: 
https://github.com/apache/maven-project-info-reports-plugin/pull/97#discussion_r1963032322


##########
src/main/java/org/apache/maven/report/projectinfo/TeamReport.java:
##########
@@ -288,32 +334,13 @@ private void renderTeamMember(Contributor member, 
Map<String, Boolean> headersMa
             sink.tableRow_();
         }
 
-        private static final String AVATAR_SIZE = "s=60";
-
-        private String getSpacerGravatarUrl() {
-            return protocol + 
"://www.gravatar.com/avatar/00000000000000000000000000000000?d=blank&f=y&" + 
AVATAR_SIZE;
-        }
-
-        private String getGravatarUrl(String email) {
-            if (email == null) {
-                return null;
-            }
-            email = StringUtils.trim(email);
-            email = email.toLowerCase();
-            MessageDigest md;
+        private String getExternalAvatarUrl(String email) {

Review Comment:
   ok, what should happen on such exception, how do you want to handle it in 
report?
   
   Now it be handled by Maven itself and build will be break.
   I hope it will not often exception.





> describe use of gravatar.com for profiles in team report
> --------------------------------------------------------
>
>                 Key: MPIR-478
>                 URL: https://issues.apache.org/jira/browse/MPIR-478
>             Project: Maven Project Info Reports Plugin
>          Issue Type: Improvement
>          Components: team
>    Affects Versions: 3.8.0
>            Reporter: Herve Boutemy
>            Assignee: Slawomir Jaranowski
>            Priority: Major
>             Fix For: 3.9.0
>
>
> like MARTIFACT-83, to clarify privacy implications
> see 
> https://github.com/apache/maven-project-info-reports-plugin/blob/master/src/main/java/org/apache/maven/report/projectinfo/TeamReport.java



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to