gnodet commented on PR #2092: URL: https://github.com/apache/maven/pull/2092#issuecomment-2647273507
> A batch method would not fundamentally change the O(N²) nature of the operation, unless it temporarily copy the list in an hash set, in which case we lost the concurrency characteristics of `CopyOnWriteArrayList`. > > I think that the first question still: do we need to care about concurrency or thread safety now, given that the rest of the class is not thread-safe? If no, we can just replace `CopyOnWriteArrayList` by `LinkedHashSet` and we are done. I don't think we need thread safety here. Thread safe > A batch method would not fundamentally change the O(N²) nature of the operation, unless it temporarily copy the list in an hash set, in which case we lost the concurrency characteristics of `CopyOnWriteArrayList`. > > I think that the first question still: do we need to care about concurrency or thread safety now, given that the rest of the class is not thread-safe? If no, we can just replace `CopyOnWriteArrayList` by `LinkedHashSet` and we are done. I don't think we do. We can defer that at the time we reverse the MavenProject implementation to be implemented on top of Project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
