[
https://issues.apache.org/jira/browse/MPLUGINTESTING-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17910543#comment-17910543
]
ASF GitHub Bot commented on MPLUGINTESTING-93:
----------------------------------------------
aamotharald commented on code in PR #50:
URL:
https://github.com/apache/maven-plugin-testing/pull/50#discussion_r1905051543
##########
maven-plugin-testing-harness/src/main/java/org/apache/maven/api/plugin/testing/InjectMojo.java:
##########
@@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.maven.plugin.testing.junit5;
+package org.apache.maven.api.plugin.testing;
Review Comment:
Hi @slachiewicz ,
yes this might collide and this I am doing by intent.
Consider the following use case:
Somebody uses `@InjectMojo`on maven version 3 and creates JUnit Jupiter test
cases to test his/her Mojo.
Then he/she decides to migrate to Maven4.
As the codelines differ between maven3/maven4, there might be glitches /
issues. But the migration will be a lot less cumbersome if you don't have to
rename all the imports just because the package changes from maven3 to maven4.
This is why I would like to have the same Packages on Maven3/4.
Does that make sense or should we strictly separate the packages and make
the maven3-4 migration cumbersome for the consumers?
PS: I made some experiments and at least for my limited use cases the
migration from maven3 to 4 with this setup went really smooth. Still thinking
how to deal with One Exception which got relocated between 3 to 4 which I plan
to provide some further solution.
> Prepare documentation / examples for JUnit 5 and Maven 3/4
> ----------------------------------------------------------
>
> Key: MPLUGINTESTING-93
> URL: https://issues.apache.org/jira/browse/MPLUGINTESTING-93
> Project: Maven Plugin Testing
> Issue Type: Task
> Reporter: Slawomir Jaranowski
> Priority: Blocker
> Attachments: image-2024-12-13-17-28-51-423.png
>
>
> We have implementation but documentation is lack ...
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
