gnodet commented on code in PR #2023:
URL: https://github.com/apache/maven/pull/2023#discussion_r1905010696
##########
api/maven-api-model/src/main/mdo/maven.mdo:
##########
@@ -104,9 +104,9 @@
<field xdoc.separator="blank">
<name>parent</name>
<version>4.0.0+</version>
- <description>The location of the parent project, if one exists.
Values from the parent
+ <description>Returns the coordinates of the parent project, if one
exists. Values from the parent
Review Comment:
> Bleah. If i had my druthers, we wouldn't generate any of this. If we're
going to use Modello to generate Javadocs, then we need to get the docs right.
>
> For the field, we can drop it. It's private and doesn't need Javadoc. Do
we have setters? We likely shouldn't.
>
> I am surprised to hear that "the javadoc is not generated anymore when
generating the Maven 3 model." If so, where did it come from? I noticed this
problem when looking at the generated code.
_anymore_ is the key word here. The Maven 3 model now wraps the Maven 4 one
and the generator has changed, loosing javadoc generation in the process.
I don't think that's a big problem though, as if people target Maven 4, they
should avoid using these classes anymore, and if they don't, they'd rather use
the Maven 3 artifacts which have the javadoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
