[ 
https://issues.apache.org/jira/browse/MNG-8486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17909647#comment-17909647
 ] 

Nils Breunese commented on MNG-8486:
------------------------------------

We were just following the jib-maven-plugin documentation, but it seems they 
either do things with system properties while they shouldn’t, or they should 
document it differently.

By now we have hundreds of apps that use this syntax in their pipelines,so if 
this was indeed not an intentional change in Maven 4 like Tamas said, then it 
would be nice if upgrading to Maven 4 won’t silently cause these properties to 
no longer work.

> User properties no longer pushed to system properties
> -----------------------------------------------------
>
>                 Key: MNG-8486
>                 URL: https://issues.apache.org/jira/browse/MNG-8486
>             Project: Maven
>          Issue Type: Bug
>    Affects Versions: 4.0.0-rc-2
>            Reporter: Nils Breunese
>            Priority: Major
>             Fix For: 4.0.0-rc-3
>
>
> I’m using {{jib-maven-plugin}} with some properties provided on the command 
> line to build a container image. According to 
> https://github.com/GoogleContainerTools/jib/tree/master/jib-maven-plugin#system-properties
>  this can be done as follows:
> {code}
> mvn compile jib:build -Djib.to.image=myregistry/myimage:latest
> {code}
> I’ve been successfully using the syntax above with Maven 3.9.9, but when I 
> try this with Maven 4.0.0-rc-2 it seems that the {{jib.to.image}} property is 
> not picked up by {{jib-maven-plugin}}.
> When I do this, it does work:
> {code}
> MAVEN_OPTS="-Djib.to.image=myregistry/myimage:latest” compile jib:build
> {code}
> I noticed that the Jib Maven Plugin documentation says that {{jib.to.image}} 
> is a (Java) _system_ property, while technically `-D` on the Maven command 
> line is for (Maven) _user_ properties.
> I've [reported this on the Maven users 
> mailinglist|https://lists.apache.org/thread/56fsshgwpb358dtw314khlpdylyffl4y] 
> and [~cstamas] explained that although at some point Maven wants to stop 
> pushing Maven user properties to Java system properties, this is not an 
> intentional change for Maven 4.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to