kwin commented on code in PR #218:
URL: https://github.com/apache/maven-parent/pull/218#discussion_r1874394478
##########
docs/pom.xml:
##########
@@ -70,8 +70,27 @@ under the License.
<!-- modules with documentation not need to install and deploy -->
<maven.install.skip>true</maven.install.skip>
<maven.deploy.skip>true</maven.deploy.skip>
+
+ <downloadDirectory>pom</downloadDirectory>
+ <downloadArtifactId>maven-parent</downloadArtifactId>
</properties>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-remote-resources-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>site-download</id>
+ <phase>pre-site</phase>
Review Comment:
right, one possible way is to set the properties only for the current pom,
but not if used as parent
(https://github.com/apache/maven-apache-parent/blob/061e19af986a914df4d37b14e7e53a079d9033c5/pom.xml#L486)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
