pzygielo commented on code in PR #350:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/350#discussion_r1871298115
##########
src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java:
##########
@@ -534,11 +534,16 @@ protected static JavaVersion getJavadocVersion(File
javadocExe)
* @return the version of the javadoc for the output, only digits and dots
* @throws PatternSyntaxException if the output doesn't match with the
output pattern
* {@code (?s).*?[^a-zA-Z]([0-9]+\\.?[0-9]*)(\\.([0-9]+))?.*}.
- * @throws IllegalArgumentException if the output is null
+ * @throws NullPointerException if the output is null
+ * @throws IllegalArgumentException if the output is empty
*/
protected static String extractJavadocVersion(String output) throws
IllegalArgumentException {
Review Comment:
I see this:
```java
protected static String extractJavadocVersion(String output) throws
IllegalArgumentException {
```
I'd like to see this instead:
```java
protected static String extractJavadocVersion(String output) throws
IllegalArgumentException, NullPointerException {
```
or this:
```java
protected static String extractJavadocVersion(String output) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
