elharo commented on PR #454: URL: https://github.com/apache/maven-dependency-plugin/pull/454#issuecomment-2520156979
For example, consider this fragment from JavadocUtiltest: ``` // Other tests version = "java full version \"1.5.0_07-164\"" + System.getProperty("line.separator"); assertEquals("1.5.0", JavadocUtil.extractJavadocVersion(version)); version = System.getProperty("line.separator") + "java full version \"1.5.0_07-164\""; assertEquals("1.5.0", JavadocUtil.extractJavadocVersion(version)); version = System.getProperty("line.separator") + "java full version \"1.5.0_07-164\"" + System.getProperty("line.separator"); assertEquals("1.5.0", JavadocUtil.extractJavadocVersion(version)); version = "java full" + System.getProperty("line.separator") + " version \"1.5.0_07-164\""; assertEquals("1.5.0", JavadocUtil.extractJavadocVersion(version)); ``` Here we test different strings depending on which platform the test runs on. We should instead run the same tests on all platforms. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org