[
https://issues.apache.org/jira/browse/MJLINK-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17902705#comment-17902705
]
ASF GitHub Bot commented on MJLINK-88:
--------------------------------------
elharo commented on code in PR #227:
URL:
https://github.com/apache/maven-jlink-plugin/pull/227#discussion_r1868064609
##########
src/test/java/org/apache/maven/plugins/jlink/JLinkMojoTest.java:
##########
@@ -61,4 +63,19 @@ void single_quotes_shell_command() throws Exception {
.isEqualTo(
"/bin/sh -c '/path/to/jlink \"--strip-debug\"
\"--module-path\" \"foo:bar\" \"--add-modules\" \"mvn,jlink\"'");
}
+
+ @Test
+ void single_quotes_shell_command_windows() throws Exception {
+
Assumptions.assumeTrue(System.getProperty("os.name").startsWith("Windows"));
Review Comment:
Neat. Haven't seen that one before. Done.
> Test failing on Windows
> -----------------------
>
> Key: MJLINK-88
> URL: https://issues.apache.org/jira/browse/MJLINK-88
> Project: Maven JLink Plugin
> Issue Type: Improvement
> Reporter: Elliotte Rusty Harold
> Assignee: Elliotte Rusty Harold
> Priority: Blocker
>
> {{ Error: Failures:
> Error: JLinkMojoTest.single_quotes_shell_command:61
> expected: "/bin/sh -c '/path/to/jlink "--strip-debug" "--module-path"
> "foo:bar" "--add-modules" "mvn,jlink"'"
> but was: "cmd.exe /X /C ""D:\path\to\jlink "--strip-debug" "--module-path"
> "foo;bar" "--add-modules" "mvn,jlink""""
> [INFO] }}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
