[
https://issues.apache.org/jira/browse/MJLINK-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17902702#comment-17902702
]
ASF GitHub Bot commented on MJLINK-88:
--------------------------------------
slawekjaranowski commented on code in PR #227:
URL:
https://github.com/apache/maven-jlink-plugin/pull/227#discussion_r1868050356
##########
src/test/java/org/apache/maven/plugins/jlink/JLinkMojoTest.java:
##########
@@ -45,12 +51,8 @@ void double_quote_every_argument() throws Exception {
}
@Test
- void single_quotes_shell_command() throws Exception {
- // given
- JLinkMojo mojo = new JLinkMojo();
- Field stripDebug = mojo.getClass().getDeclaredField("stripDebug");
- stripDebug.setAccessible(true);
- stripDebug.set(mojo, Boolean.TRUE);
+ void single_quotes_shell_command_unix() throws Exception {
+
Assumptions.assumeFalse(System.getProperty("os.name").startsWith("Windows"));
Review Comment:
There is an annotation `@DisabledOnOs`
> Test failing on Windows
> -----------------------
>
> Key: MJLINK-88
> URL: https://issues.apache.org/jira/browse/MJLINK-88
> Project: Maven JLink Plugin
> Issue Type: Improvement
> Reporter: Elliotte Rusty Harold
> Assignee: Elliotte Rusty Harold
> Priority: Blocker
>
> {{ Error: Failures:
> Error: JLinkMojoTest.single_quotes_shell_command:61
> expected: "/bin/sh -c '/path/to/jlink "--strip-debug" "--module-path"
> "foo:bar" "--add-modules" "mvn,jlink"'"
> but was: "cmd.exe /X /C ""D:\path\to\jlink "--strip-debug" "--module-path"
> "foo;bar" "--add-modules" "mvn,jlink""""
> [INFO] }}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
