gnodet commented on code in PR #77:
URL: https://github.com/apache/maven-archiver/pull/77#discussion_r1858944751
##########
src/main/java/org/apache/maven/archiver/PomPropertiesUtil.java:
##########
@@ -71,8 +71,8 @@ private void createPropertiesFile(Properties properties, Path
outputFile, boolea
return;
}
- try (PrintWriter pw = new PrintWriter(outputFile.toFile(),
StandardCharsets.ISO_8859_1.name());
- StringWriter sw = new StringWriter()) {
+ try ( Writer writer = Files.newBufferedWriter(outputFile,
StandardCharsets.ISO_8859_1);
Review Comment:
The `loadPropertiesFile` method let the `Properties` class decide the
charset used (so it's using ISO_8859_1, as it's the default). I think we
should use an `OutputStream` here and pass it to `properties.store()` without
the charset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
