[
https://issues.apache.org/jira/browse/MCHECKSTYLE-453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17900155#comment-17900155
]
ASF GitHub Bot commented on MCHECKSTYLE-453:
--------------------------------------------
elharo commented on code in PR #160:
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/160#discussion_r1852275271
##########
src/main/java/org/apache/maven/plugins/checkstyle/exec/DefaultCheckstyleExecutor.java:
##########
@@ -49,28 +52,33 @@
import org.apache.maven.artifact.DependencyResolutionRequiredException;
import org.apache.maven.model.Resource;
import org.apache.maven.project.MavenProject;
-import org.codehaus.plexus.component.annotations.Component;
-import org.codehaus.plexus.component.annotations.Requirement;
import org.codehaus.plexus.logging.AbstractLogEnabled;
import org.codehaus.plexus.resource.ResourceManager;
import org.codehaus.plexus.resource.loader.FileResourceCreationException;
import org.codehaus.plexus.resource.loader.FileResourceLoader;
import org.codehaus.plexus.resource.loader.ResourceNotFoundException;
import org.codehaus.plexus.util.FileUtils;
+import org.eclipse.sisu.Typed;
/**
* @author Olivier Lamy
* @since 2.5
- *
*/
-@Component(role = CheckstyleExecutor.class, hint = "default",
instantiationStrategy = "per-lookup")
+@Named("default")
+@Typed(CheckstyleExecutor.class)
Review Comment:
For some reason Sisu doesn't recognize this as a possible fulfillment of
CheckstyleExecutor
> Convert injection to Sisu Guice
> -------------------------------
>
> Key: MCHECKSTYLE-453
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-453
> Project: Maven Checkstyle Plugin
> Issue Type: Dependency upgrade
> Reporter: Elliotte Rusty Harold
> Assignee: Elliotte Rusty Harold
> Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
