peterdemaeyer commented on code in PR #62:
URL: https://github.com/apache/maven-clean-plugin/pull/62#discussion_r1841650362
##########
src/main/java/org/apache/maven/plugins/clean/Cleaner.java:
##########
@@ -96,10 +100,10 @@ class Cleaner {
* @throws IOException If a file/directory could not be deleted and
<code>failOnError</code> is <code>true</code>.
*/
public void delete(
- File basedir, Selector selector, boolean followSymlinks, boolean
failOnError, boolean retryOnError)
+ Path basedir, Selector selector, boolean followSymlinks, boolean
failOnError, boolean retryOnError)
Review Comment:
I did not consider this part API because the whole `Cleaner` class is
package-private. So this method is effectively package-private too, even though
it has the `public` keyword.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
