elharo commented on code in PR #62:
URL: https://github.com/apache/maven-clean-plugin/pull/62#discussion_r1841592978
##########
src/main/java/org/apache/maven/plugins/clean/CleanMojo.java:
##########
@@ -197,7 +199,7 @@ public class CleanMojo extends AbstractMojo {
* waiting for all files to be deleted when the session ends,
<code>at-end</code> to indicate that the actual
* deletion should be performed synchronously when the session ends, or
<code>defer</code> to specify that
* the actual file deletion should be started in the background when the
session ends (this should only be used
- * when maven is embedded in a long running process).
+ * when maven is embedded in a long-running process).
Review Comment:
period inside parentheses
##########
src/main/java/org/apache/maven/plugins/clean/CleanMojo.java:
##########
@@ -197,7 +199,7 @@ public class CleanMojo extends AbstractMojo {
* waiting for all files to be deleted when the session ends,
<code>at-end</code> to indicate that the actual
* deletion should be performed synchronously when the session ends, or
<code>defer</code> to specify that
* the actual file deletion should be started in the background when the
session ends (this should only be used
Review Comment:
session ends. (This should only be used
##########
src/main/java/org/apache/maven/plugins/clean/Cleaner.java:
##########
@@ -96,10 +100,10 @@ class Cleaner {
* @throws IOException If a file/directory could not be deleted and
<code>failOnError</code> is <code>true</code>.
*/
public void delete(
- File basedir, Selector selector, boolean followSymlinks, boolean
failOnError, boolean retryOnError)
+ Path basedir, Selector selector, boolean followSymlinks, boolean
failOnError, boolean retryOnError)
Review Comment:
what's our commitment on API compatibility here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
