[
https://issues.apache.org/jira/browse/MRESOLVER-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897908#comment-17897908
]
ASF GitHub Bot commented on MRESOLVER-627:
------------------------------------------
cstamas opened a new pull request, #599:
URL: https://github.com/apache/maven-resolver/pull/599
In previous releases transport selection was really secretive and broken, as
it considered invalid configuration as "protocol not supported" and Resolver
did not log anything or worse, silently skipped to new transport.
Changes:
* transport provider: was logging ONLY if transport selection failed (no
transport was selected), changed to continuously log (in DEBUG) why a transport
was ignored and next selection performed. Also, in case of total failure,
exceptions are added now as suppressed ones instead just lost.
* multiple transporter factories: smaller fixes for earlier protocol
detection (file is exception to support cases like JIMFS), and when client
creation is attempted but it fails due runtime exception, fail the whole
process (like bad enum in JDK transport config).
---
https://issues.apache.org/jira/browse/MRESOLVER-627
> Improve handling and logging around transport selection
> -------------------------------------------------------
>
> Key: MRESOLVER-627
> URL: https://issues.apache.org/jira/browse/MRESOLVER-627
> Project: Maven Resolver
> Issue Type: Improvement
> Components: Resolver
> Affects Versions: 2.0.3
> Reporter: Tamas Cservenak
> Priority: Major
> Fix For: 2.0.4
>
>
> Currently what transport is being used by Resolver is fully black box.
> Examples:
> * configure Maven 4 that by default would use JDK transport, create
> {{.mvn/maven.config}} file with contents
> {{-Daether.transport.jdk.httpVersion=HTTP_1_2}} (intentional typo). What
> happens: Maven 4 will work but use Apache Transport.
> * configure Maven 4 to use S3 transport but do not provide auth config. What
> happens? Dependending on config, either some other transport will be selected
> (and fail), or Resolver will tell "no available transport", which is untrue.
> * even in Maven -X resolver reports only what is to be used, but not why some
> transport was ignored/skipped (see case 1: jdk transport bad config)
> In both cases, Resolver config is bad, but:
> * it is not reported anywhere
> * in fact, it is silently ignored and Resolver continues like nothing happened
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
