kwin commented on code in PR #85:
URL:
https://github.com/apache/maven-doxia-converter/pull/85#discussion_r1835347032
##########
src/main/java/org/apache/maven/doxia/DefaultConverter.java:
##########
@@ -248,14 +249,21 @@ public void convert(InputFileWrapper input,
OutputFileWrapper output)
for (File f : files) {
File relativeOutputDirectory = new File(
PathTool.getRelativeFilePath(input.getFile().getAbsolutePath(), f.getParent()));
- parse(f, input.getEncoding(), input.getFormat(), output,
relativeOutputDirectory);
+ convert(f, input.getEncoding(), input.getFormat(), output,
relativeOutputDirectory);
+ cleanUp(input, f);
}
}
} finally {
stopPlexusContainer();
}
}
+ private void cleanUp(InputFileWrapper input, File f) {
+ if (input.cleanUp(f)) {
+ LOGGER.info("Removed input file \"{}\" after successfull
conversion", f);
Review Comment:
For me this is worth to be always emitted as when giving a directory as
input parameter it is otherwise not clear which files within are removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
