elharo commented on code in PR #60:
URL: https://github.com/apache/maven-clean-plugin/pull/60#discussion_r1833170592
##########
src/test/java/org/apache/maven/plugins/clean/CleanerTest.java:
##########
@@ -45,36 +42,22 @@
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertInstanceOf;
import static org.junit.jupiter.api.Assertions.assertThrows;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.eq;
+import static org.mockito.Mockito.inOrder;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.never;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
class CleanerTest {
- private boolean warnEnabled;
-
- /**
- * Use a {@code LinkedHashMap} to preserve the order of the logged
warnings.
- */
- private final Map<CharSequence, Throwable> warnings = new
LinkedHashMap<>();
-
- /**
- * Ideally we should use a mocking framework such as Mockito for this, but
alas, this project has no such dependency.
- */
- private final Log log = new SilentLog() {
-
- @Override
- public boolean isWarnEnabled() {
- return warnEnabled;
- }
-
- @Override
- public void warn(CharSequence content, Throwable error) {
- warnings.put(content, error);
- }
- };
+ private final Log log = mock();
@Test
void deleteSucceedsDeeply(@TempDir Path tempDir) throws Exception {
- final Path basedir = createDirectory(tempDir.resolve("target"));
+ final Path basedir =
createDirectory(tempDir.resolve("target")).toRealPath();
Review Comment:
might want to do this in a separate pr first
##########
src/main/java/org/apache/maven/plugins/clean/Cleaner.java:
##########
@@ -273,7 +273,8 @@ private boolean isSymbolicLink(Path path) throws
IOException {
* @throws IOException If a file/directory could not be deleted and
<code>failOnError</code> is <code>true</code>.
*/
private int delete(File file, boolean failOnError, boolean retryOnError)
throws IOException {
- if (!file.delete()) {
+ IOException error = delete(file);
Review Comment:
this is not a Java error; please rename the variable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
