[
https://issues.apache.org/jira/browse/MCHECKSTYLE-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896102#comment-17896102
]
ASF GitHub Bot commented on MCHECKSTYLE-408:
--------------------------------------------
JackPGreen commented on PR #155:
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/155#issuecomment-2460846930
> Looks good. I would only request a chance on name of class to be something
like MavenConsoleLogger
>
>
https://github.com/checkstyle/checkstyle/blob/aadc3771a2219e784cd7611213fd7f6534da7cb8/src/main/java/com/puppycrawl/tools/checkstyle/DefaultLogger.java#L42
> To be clear, are you requesting I rename the [`ConsoleListener`
class](https://github.com/apache/maven-checkstyle-plugin/blob/91ca4b84368e680b5665b09fea500f65a6a111ae/src/main/java/org/apache/maven/plugins/checkstyle/ConsoleListener.java)
to something like `MavenLoggingListener`?
> To MavenConsoleLogger
>
> But if there are some concerns, I am ok with any name. This is not a
project where I enforce rules.
Updated -
https://github.com/apache/maven-checkstyle-plugin/pull/155/commits/ab8afc01f8837684b195559981901a26c6a91a82
> Audit events should use Maven logging
> -------------------------------------
>
> Key: MCHECKSTYLE-408
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-408
> Project: Maven Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 3.1.2
> Reporter: Nas Kavian
> Assignee: Michael Osipov
> Priority: Major
>
> **How it works Now:**
> ```bash
> [INFO] — maven-checkstyle-plugin:3.1.2:checkstyle (default-cli) @ project —
> [INFO] Starting audit...
> ... other checkstyle output ...
> Audit done.
> [INFO]
> ```
> **Desired output**
> ```bash
> [INFO] — maven-checkstyle-plugin:3.1.2:checkstyle (default-cli) @ project —
> [INFO] Starting audit...
> ... other non-indented checkstyle output is okay ...
> [INFO] Audit done.
> [INFO]
> ```
> **So that the output is aligned when there are no violations**
> ```bash
> [INFO] — maven-checkstyle-plugin:3.1.2:checkstyle (default-cli) @ project —
> [INFO] Starting audit...
> [INFO] Audit done.
> [INFO]
> ```
> **Similar to SpotBugs and PMD output**
> ```bash
> [INFO] — spotbugs-maven-plugin:4.3.0:spotbugs (spotbugs) @ project —
> [INFO] Fork Value is true
> [INFO] Done SpotBugs Analysis....
> [INFO]
> [INFO] — maven-pmd-plugin:3.14.0:check (default-cli) @ project —
> [INFO] PMD version: 6.37.0
> [INFO]
> ```
> Originally wrote this issue in GitHub against the Checkstyle project, they
> asked to move it here.
> [https://github.com/checkstyle/checkstyle/issues/10775]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
