stokito opened a new pull request, #1813: URL: https://github.com/apache/maven/pull/1813
The Maven used the own inception year 2001. But the Gradle already use the 1 Feb 1980 for preserveFileTimestamps. The 1 Jan 1980 is a minimal date in Zip archive but the 1 Jan has some special treatment by Java that's why the Gradle team used the 1 Feb. See more detailed description in CONSTANT_TIME_FOR_ZIP_ENTRIES https://github.com/gradle/gradle/blob/master/platforms/core-runtime/files/src/main/java/org/gradle/api/internal/file/archive/ZipEntryConstants.java#L39 The change was first proposed in the https://github.com/apache/maven/pull/1726#issuecomment-2376407039 and also slightly discussed in the MSHARED-1430 > @hboutemy: > many people have many opinions: there are even more opinions than people > The default value has been added in [MNG-8258](https://issues.apache.org/jira/browse/MNG-8258) with a Maven-specific timestamp (no reason to try to mimic others: there is no perfect or wrong choice) > @stokito: > Sure, but a standardization always improves and simplifies things (if done right). Having the same value 1 Feb 1980 will simplify search "Why my jar has the weird date? You have the reproducible build. Ah, ok, ty". But also I switch from Gradle to Maven then if would be less differences in artifacts. Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG-8258) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. - [x] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`. Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
