stokito commented on code in PR #266:
URL:
https://github.com/apache/maven-compiler-plugin/pull/266#discussion_r1792987182
##########
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##########
@@ -1152,9 +1152,7 @@ public void execute() {
}
}
- if (outputTimestamp != null
- && !outputTimestamp.isEmpty()
- && (outputTimestamp.length() > 1 ||
Character.isDigit(outputTimestamp.charAt(0)))) {
+ if (StringUtils.isNotBlank(outputTimestamp)) {
Review Comment:
The `outputTimestamp.length() > 1` really confused me. The one char (not
digit) will make the `outputTimestamp` ignored as if it was empty.
It looks like I understood why the one char will be ignored. In JIRA I found
this:
"disable it
`<project.build.outputTimestamp>x</project.build.outputTimestamp>`".
In the maven-archiver
https://github.com/apache/maven-archiver/blob/master/src/main/java/org/apache/maven/archiver/MavenArchiver.java#L703
there is more explanation
// no timestamp configured (1 character configuration is useful to
override a full value during pom
// inheritance)
if (outputTimestamp.length() < 2) {
return Optional.empty();
}
So my PR is invalid. But the `x` value needs to be specified clearly maybe
if not in code but at least in comments and documentation.
I would rather introduce a special constant value like NO_INHERIT or
something like that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
