[
https://issues.apache.org/jira/browse/DOXIA-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17887379#comment-17887379
]
Konrad Windszus edited comment on DOXIA-746 at 10/7/24 3:49 PM:
----------------------------------------------------------------
I am talking about APTParser and MarkdownSink/Html5Sink. Since comments in
general are inline in HTML5 I don't expect the sink to always add line
delimiters, otherwise stuff like
{code}
<!--START comment --><h1>headline<h1><!-- END comment-->
{code}
would no longer be possible to emit with the Html5Sink.
I don't see any need to restrict in line comments in HTML/Markdown!
was (Author: kwin):
I am talking about APTParser and MarkdownSink/Html5Sink. Since comments in
general are inline in HTML5 I don't expect the sink to always add line
delimiters, otherwise stuff like
{code}
<!--START comment --><h1>headline<h1><!-- END comet-->
{code}
would no longer be possible to emit with the Html5Sink.
I don't see any need to restrict in line comments in HTML/Markdown!
> MarkdownSink: Comment missing EOLs
> ----------------------------------
>
> Key: DOXIA-746
> URL: https://issues.apache.org/jira/browse/DOXIA-746
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Markdown
> Affects Versions: 2.0.0
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Major
>
> The sink API is not clear about whether comments are block or inline elements
> (although never rendered the question is how they should appear in the markup
> sources)
> In APT
> [comments|https://maven.apache.org/doxia/references/apt-format.html#comment]
> always end with the line ending (as there is no dedicated end comment
> delimiter).
> OTOH in markdown/html they have a dedicated end character.
> Currently two consecutive comments in APT are emitted as
> {code}
> sink.comment("comment1")
> sink.comment("comment2")
> {code}
> In APT they are separated by newlines but in Sink API and Markdown/HTML they
> are not.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
