[ https://issues.apache.org/jira/browse/DOXIA-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17887359#comment-17887359 ]
Konrad Windszus edited comment on DOXIA-746 at 10/7/24 2:19 PM: ---------------------------------------------------------------- If you consider the LS part of the comment this will lead to the following HTML/Markdown {code} <!-- comment1 --><!-- comment2 --> {code} what is intended is {code} <!-- comment1--> <!-- comment2--> {code} was (Author: kwin): If you consider the LS part of the comment this will lead to the following HTML {code} <!-- comment1 --><!-- comment2 --> {code} what is intended is {code} <!-- comment1--> <!-- comment2--> {code} > MarkdownSink: Comment missing EOLs > ---------------------------------- > > Key: DOXIA-746 > URL: https://issues.apache.org/jira/browse/DOXIA-746 > Project: Maven Doxia > Issue Type: Bug > Components: Module - Markdown > Affects Versions: 2.0.0 > Reporter: Konrad Windszus > Assignee: Konrad Windszus > Priority: Major > > The sink API is not clear about whether comments are block or inline elements > (although never rendered the question is how they should appear in the markup > sources) > In APT > [comments|https://maven.apache.org/doxia/references/apt-format.html#comment] > always end with the line ending (as there is no dedicated end comment > delimiter). > OTOH in markdown/html they have a dedicated end character. > Currently two consecutive comments in APT are emitted as > {code} > sink.comment("comment1") > sink.comment("comment2") > {code} > In APT they are separated by newlines but in Sink API and Markdown/HTML they > are not. -- This message was sent by Atlassian Jira (v8.20.10#820010)