[
https://issues.apache.org/jira/browse/DOXIA-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17887360#comment-17887360
]
Michael Osipov commented on DOXIA-746:
--------------------------------------
Maybe I was not explicit enough: The sink impl must add the LS on its own if
the syntax requires it. Much like Python's indentation. The latter looks good
to me -- and right.
> MarkdownSink: Comment missing EOLs
> ----------------------------------
>
> Key: DOXIA-746
> URL: https://issues.apache.org/jira/browse/DOXIA-746
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Markdown
> Affects Versions: 2.0.0
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Major
>
> The sink API is not clear about whether comments are block or inline elements
> (although never rendered the question is how they should appear in the markup
> sources)
> In APT
> [comments|https://maven.apache.org/doxia/references/apt-format.html#comment]
> always end with the line ending (as there is no dedicated end comment
> delimiter).
> OTOH in markdown/html they have a dedicated end character.
> Currently two consecutive comments in APT are emitted as
> {code}
> sink.comment("comment1")
> sink.comment("comment2")
> {code}
> In APT they are separated by newlines but in Sink API and Markdown/HTML they
> are not.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
