michael-o commented on code in PR #120:
URL: https://github.com/apache/maven-gpg-plugin/pull/120#discussion_r1773041660
##########
src/main/java/org/apache/maven/plugins/gpg/AbstractGpgMojo.java:
##########
@@ -270,6 +270,20 @@ public abstract class AbstractGpgMojo extends AbstractMojo
{
@Parameter(property = "gpg.bestPractices", defaultValue = "false")
private boolean bestPractices;
+ /**
+ * Whether to append the passphrase with LF character or not, as on some
systems and some GPG executable combinations
+ * lack of this character may cause GPG to not detect passphrase on STDIN.
Since 3.2.0 it was always appended, unless
+ * passphrase itself ended with line separator. This parameter affects
ONLY the GPG signer, not the BC signer.
+ * <p>
+ * By default, this parameter is {@code true} to retain same behaviour as
before.
+ *
+ * @since 3.2.7
+ * @see <a href="https://issues.apache.org/jira/browse/MGPG-99";>MGPG-99</a>
+ * @see <a
href="https://issues.apache.org/jira/browse/MGPG-136";>MGPG-136</a>
+ */
+ @Parameter(property = "gpg.passphraseLf", defaultValue = "true")
+ private boolean passphraseLf;
Review Comment:
I think this parameter should just be `terminatePassphrase`
##########
src/main/java/org/apache/maven/plugins/gpg/AbstractGpgMojo.java:
##########
@@ -270,6 +270,20 @@ public abstract class AbstractGpgMojo extends AbstractMojo
{
@Parameter(property = "gpg.bestPractices", defaultValue = "false")
private boolean bestPractices;
+ /**
+ * Whether to append the passphrase with LF character or not, as on some
systems and some GPG executable combinations
Review Comment:
Whether to to terminate the passphrase with the LF character or not, ....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
