[ 
https://issues.apache.org/jira/browse/MNG-8233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17879184#comment-17879184
 ] 

Tamas Cservenak commented on MNG-8233:
--------------------------------------

Diff between Maven 3.9.x:
In 3.9.x ModelData relevant bit looks like this:
https://github.com/apache/maven/blob/maven-3.9.x/maven-model-builder/src/main/java/org/apache/maven/model/building/ModelData.java#L185-L200

But in master ModelData is changed to this (hence paths):
https://github.com/apache/maven/blob/master/maven-model-builder/src/main/java/org/apache/maven/model/building/ModelData.java#L108-L116

Still some other parts still imply that modelId is {{G:A:V}} as this one here:
https://github.com/apache/maven/blob/master/api/maven-api-core/src/main/java/org/apache/maven/api/services/ModelBuilderResult.java#L37-L46

IMO, either GAV or paths, we may want to state clearly that modelId keys are 
"opaque strings" (as even manually constructing GAVs is not good, as super pom 
is "" empty string)

> ModelIDs are paths, possible mixup in project or model builder
> --------------------------------------------------------------
>
>                 Key: MNG-8233
>                 URL: https://issues.apache.org/jira/browse/MNG-8233
>             Project: Maven
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 4.0.0-beta-3
>            Reporter: Tamas Cservenak
>            Priority: Major
>             Fix For: 4.0.0-beta-5
>
>         Attachments: image.png
>
>
> While debugging occured to me that modelIds that are usually {{G:A:V}} or 
> alike formed, are in fact paths. Example debug session screenshot attached 
> (while working on MNG-8229): parentModelId is obviously a path, not "model 
> ID", class maven-core:org.apache.maven.project.DefaultProjectBuilder.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to