gnodet commented on PR #229:
URL: https://github.com/apache/maven-release/pull/229#issuecomment-2322880587
> > however, don't really see how it could cope with something like the
Jenkins one: ${revision}${changelist}... which placeholder should be updated ?
>
> Tycho version plugin supports updating such properties with a little
restriction that only one of them can be updated (usually the last part) that
has to be a Number by default.
>
> e.g. if `${revision}${changelist}` maps to `<revision>1.0</revision>` and
`<changelist>-SNAPSHOT</changelist>` and one updates the version to
`1.1-SNAPSHOT` it first checks the `changelist` is a suffix of the new version
then leave this alone, now check `revision` what is not a suffix anymore so
change `revision` -> `1.1`, this already covers the most usual cases.
What's the use case for using multiple placeholders such as
`${revision}${changelist}`, especially when/if we open those properties a bit
more to any _user defined_ properties. If I look at the Jenkins use case,
`revision` is the usual version, and `changelist` is `-SNAPSHOT`, unless it's
an automatic deploy in which case `changelist` is computed from the git
revision.
So the real use case afaik, and I think Tycho has a similar requirement, is
that the version for a given component is computed at runtime and not hardcoded
in the POM.
I don't think there's a real need to support two components here. What's
the benefit here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
