gnodet commented on PR #229:
URL: https://github.com/apache/maven-release/pull/229#issuecomment-2322848274
> @gnodet Since you are also on the CI friendy track. Which PR do you
prefer? This one or #230? I believe that what we have in Release now is
incomplete/broken, I'd prefer to revert it until we have something better. WDYT?
This is definitely open to discussion, but I'm thinking right now is that
friendly should be static after the file models have been read. So CI-friendly
versions can be handled by a transformer that would be called between the file
model being read and the file model being validated.
In addition, I think the default implementation should limit to _user
properties_, but not use _project properties_. The problem with _project
properties_ is that you only have the real values from the _effective_ model,
but the _file_ model. And that's really what causes all kind of problems in
Maven, as the CI version is actually handled during the file -> raw
transformation.
If we go that way, that would mean the best location for those properties
would be `[root]/.mvn/maven.properties`. The release plugin would have to be
adapted, but given the model validation would ensure the versions are constants
in the file model, I would not necessarily restrict the release plugin to any
kind of key for substitution. However, don't really see how it could cope with
something like the Jenkins one: `${revision}${changelist}`... which placeholder
should be updated ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
