[
https://issues.apache.org/jira/browse/MSKINS-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878167#comment-17878167
]
Konrad Windszus commented on MSKINS-250:
----------------------------------------
Also parametrization in
[https://github.com/apache/maven-fluido-skin/blob/85da1de45c085ccc826dd91152bec54e4cf576b1/src/main/resources/META-INF/maven/site-macros.vm#L151]
seem slightly off as the 4th argument is actually supposed to be a string (but
is a boolean) and the 5th one is supposed to be a boolean (but is a string).
> bannerLeft/Right have external link decoration when consisting only out of
> image
> --------------------------------------------------------------------------------
>
> Key: MSKINS-250
> URL: https://issues.apache.org/jira/browse/MSKINS-250
> Project: Maven Skins
> Issue Type: Bug
> Components: Fluido Skin
> Affects Versions: fluido-2.0.0-M10
> Reporter: Konrad Windszus
> Priority: Major
>
> I have the following snippet in my site descriptor (v1.8)
> {code}
> <bannerLeft>
> <name>My Name</name>
> <src>someimage.png</src>
> <href>https://google.com/</href>
> </bannerLeft>
> {code}
> with Fluido 1.12.0 this renders the image only, i.e.
> {code}
> <div id="banner">
> <div class="pull-left"><a href="https://google.com/"
> id="bannerLeft"><img src="someimage.png" alt="My Name" style="" /></a></div>
> {code}
> With Fluido 2.0.0-M10 and Site Descriptor 2.0:
> {code}
> <bannerLeft href="https://google.com/">
> <image src="someimage.png" />
> </bannerLeft>
> {code}
> it renders as
> {code}
> <div id="bannerLeft"><h1><a href="https://google.com/"
> class="externalLink"><img class="imageLink" src="someimage.png"
> /></a></h1></div>
> {code}
> The class {{externalLink}} leads to an additional unwanted decorator next to
> the image.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)