AlexanderAshitkin commented on code in PR #176:
URL:
https://github.com/apache/maven-build-cache-extension/pull/176#discussion_r1732039886
##########
src/main/java/org/apache/maven/buildcache/CacheControllerImpl.java:
##########
@@ -255,6 +255,11 @@ private CacheResult analyzeResult(CacheContext context,
List<MojoExecution> mojo
build.getCacheImplementationVersion());
}
+ if (lifecyclePhasesHelper.isLaterPhaseThanBuild("package", build))
{
+ LOGGER.warn("Cached build doesn't include phase 'package',
cannot restore");
Review Comment:
In the current implementation, the 'analyzeResult' returns partial success
in lines 277-278 as expected.
More accurate implementation could support pre-compile phases - 'save' and
restore generated sources. This will allow restoring missing sources from the
cache and potentially saving time on the code generation. Could be handy in
IDEs which could compile the project if generated sources are restored.
The second concern is that we still process builds that will never be used
in the 'save'. Save and restore should be consistent, and the situation when
cached builds are not usable should also be considered for improvement.
Though overall, as a quick fix, this change seems legitimate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
