[
https://issues.apache.org/jira/browse/SUREFIRE-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876324#comment-17876324
]
ASF GitHub Bot commented on SUREFIRE-2252:
------------------------------------------
ArvindJoshi-okta opened a new pull request, #772:
URL: https://github.com/apache/maven-surefire/pull/772
### Problem
- When parallel tests are executed in JUnit5, the reporting (console and
xml) have some issues
- The tests are executed but the reporting combines tests into other classes
showing incorrect results (as seen below)
- Sample code is attached to the JIRA
https://issues.apache.org/jira/browse/SUREFIRE-2252
```
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.example.ClassBIT
[INFO] Running org.example.ClassAIT
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.026
s – in org.example.ClassAIT
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.026
s – in org.example.ClassBIT
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0
```
### Fix
- Issue was in `JUnitPlatformProvider` where the `execute` method was
sending in all the classes at the same time in class selector list, hence
combining the results
- Fix was to move the list creation inside the iteration loop
- Added relevant unit and integration tests
### Checklist
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/SUREFIRE) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `SUREFIRE-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean install` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean
install`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> Failsafe xml for a test class has results from another class
> ------------------------------------------------------------
>
> Key: SUREFIRE-2252
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2252
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin
> Affects Versions: 3.2.5, 3.3.1
> Environment: Maven/JUnit5/Mac
> Reporter: Arvind Joshi
> Priority: Blocker
> Attachments: ClassAIT.java, ClassBIT.java,
> TEST-org.example.ClassAIT.xml, TEST-org.example.ClassBIT.xml, pom.xml
>
>
> *Issue*
> When I execute tests concurrently (at class level), I see the failsafe xmls
> being generated, but the test methods themselves seem to be mixed up with
> other classes.
> *Expectation*
> Each failsafe xml is unique to a class, which was the case with the JUnit4
> provider.
> *Versions*
> maven failsafe plugin 3.2.5 or 3.3.1
> JUnit 5.10.2
> *Sample code and Test results*
> Please see attached files
> *Running the tests attached*
>
> {noformat}
> mvn clean verify -Pparallel-tests{noformat}
>
>
> {noformat}
> [INFO] -------------------------------------------------------
> [INFO] T E S T S
> [INFO] -------------------------------------------------------
> [INFO] Running org.example.ClassBIT
> [INFO] Running org.example.ClassAIT
> [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.026
> s – in org.example.ClassAIT
> [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.026
> s – in org.example.ClassBIT
> [INFO]
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
