[ https://issues.apache.org/jira/browse/MNG-8222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876257#comment-17876257 ]
ASF GitHub Bot commented on MNG-8222: ------------------------------------- gnodet commented on code in PR #1679: URL: https://github.com/apache/maven/pull/1679#discussion_r1728905518 ########## api/maven-api-core/src/main/java/org/apache/maven/api/ProtoSession.java: ########## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.api; + +import java.nio.file.Path; +import java.util.Map; + +import org.apache.maven.api.annotations.Experimental; +import org.apache.maven.api.annotations.Nonnull; +import org.apache.maven.api.annotations.ThreadSafe; + +/** + * The proto session, material used to create {@link Session}. + * + * @since 4.0.0 + */ +@Experimental +@ThreadSafe +public interface ProtoSession { + Review Comment: Maybe just a `List<String>` to not expose commons-cli. > Provide more information to PropertyContributors > ------------------------------------------------ > > Key: MNG-8222 > URL: https://issues.apache.org/jira/browse/MNG-8222 > Project: Maven > Issue Type: Improvement > Components: API > Affects Versions: 4.0.0-beta-3 > Reporter: Tamas Cservenak > Priority: Major > Fix For: 4.0.0-beta-4 > > > The property contributor lacks a lot of "contextual" data. It would be better > if it could: > * inspect "so far discovered user properties" -- this is OK, they are in the > passed in map > * inspect "maven discovered Java System Properties" -- to not touch > System.getProperty method > * inspect maybe things like topDirectory, cwd etc? -- This message was sent by Atlassian Jira (v8.20.10#820010)