[
https://issues.apache.org/jira/browse/MNG-8211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17875794#comment-17875794
]
Tamas Cservenak edited comment on MNG-8211 at 8/22/24 10:07 AM:
----------------------------------------------------------------
In short: we deal with two things here: in memory "effective model" that is
built, and the POM file from the disk (used to build "effective model").
Important thing to understand, is that these two are "disconnected", in a way,
once effective model is built, and possibly altered (like with injection of
user property for version), the original POM file remains unchanged!
The existing "CI friendly versions" feature allows *dynamic* versions to be
injected into version (so, *allows property* in place of project.version) but
*it did not validate that replacement did happen*! This is alleviated by this
issue, as many times users deployed something that had version {{${revision}}}
and was only a source of confusion for them. Also, CI friendly versions
documentation *clearly states* that [such deployed things are
*unusable*|https://maven.apache.org/maven-ci-friendly.html#install-deploy] by
other projects. Hence, in 99.9% we can say this is NOT what users wanted to
deploy. Hence, IMHO Maven should fail the build if dynamic version injection
did not happen (due any reason).
was (Author: cstamas):
In short: we deal with two things here: in memory "effective model" that is
built from the POM file on disk.
The existing "CI friendly versions" feature allows *dynamic* versions to be
injected into version (so, *allows property* in place of project.version) but
*it did not validate that replacement did happen*! This is alleviated by this
issue, as many times users deployed something that had version {{${revision}}}
and was only a source of confusion for them. Also, CI friendly versions
documentation *clearly states* that [such deployed things are
*unusable*|https://maven.apache.org/maven-ci-friendly.html#install-deploy] by
other projects. Hence, in 99.9% we can say this is NOT what users wanted to
deploy. Hence, IMHO Maven should fail the build if dynamic version injection
did not happen (due any reason).
> Maven should fail builds that use CI Friendly versions but have no values set
> -----------------------------------------------------------------------------
>
> Key: MNG-8211
> URL: https://issues.apache.org/jira/browse/MNG-8211
> Project: Maven
> Issue Type: Bug
> Components: Core
> Reporter: Tamas Cservenak
> Priority: Major
> Fix For: 4.0.0, 4.0.0-beta-4, 3.9.10
>
>
> As otherwise it is just source of confusion, Maven will "happily" install and
> deploy artifacts as {{G:A:$revision}} and this is 100% NOT what users wants.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
