[
https://issues.apache.org/jira/browse/MNG-8214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874500#comment-17874500
]
ASF GitHub Bot commented on MNG-8214:
-------------------------------------
kwin commented on PR #1660:
URL: https://github.com/apache/maven/pull/1660#issuecomment-2294852304
> However the use case of ExtendedMojoDescriptor is definitely a bad one.
I only partially agree, extending the MDO for this case is not useful as the
additional attribute really only is useful in the plugin-tools context and
therefore this class is only used internally. Although one could probably do
things differently, the effort when not extending the original Maven classes is
considerably higher (as one somehow needs to establish the connection between
the raw Maven object and the extended plugin tools one).
> Allow extension of the model classes being generated with model.vm
> ------------------------------------------------------------------
>
> Key: MNG-8214
> URL: https://issues.apache.org/jira/browse/MNG-8214
> Project: Maven
> Issue Type: Improvement
> Affects Versions: 4.0.0-beta-3
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Major
>
> The [model.vm|https://github.com/apache/maven/blob/master/src/mdo/model.vm]
> being used with Maven 4 models generates immutable classes with builders. The
> generated classes cannot be extended easily because
> # the builder's constructor is having default access instead of being
> protected
> (https://github.com/apache/maven/blob/e335f95dfd11468bdf617421fd5e7093a727d1e1/src/mdo/model.vm#L409
> and
> https://github.com/apache/maven/blob/e335f95dfd11468bdf617421fd5e7093a727d1e1/src/mdo/model.vm#L427
> # the classes constructor doesn't take a builder as argument (therefore the
> subclass cannot leverage reuse most of the functionality currently
> encapsulated by the Builder)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
