[
https://issues.apache.org/jira/browse/MENFORCER-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17869678#comment-17869678
]
ASF GitHub Bot commented on MENFORCER-508:
------------------------------------------
kwin commented on code in PR #328:
URL: https://github.com/apache/maven-enforcer/pull/328#discussion_r1697180065
##########
enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/RequireSameVersions.java:
##########
@@ -85,6 +91,13 @@ public void execute() throws EnforcerRuleException {
}
throw new EnforcerRuleException(builder.toString());
}
+
+ if (sameModuleVersions) {
+ MavenProject topLevelProject = session.getTopLevelProject();
+ if (project != topLevelProject &&
!Objects.equals(topLevelProject.getVersion(), project.getVersion())) {
Review Comment:
is it always same project instances or do I need to compare via equals?
> Extend requireSameVersions rule to optionally enforce same versions among
> reactor modules
> -----------------------------------------------------------------------------------------
>
> Key: MENFORCER-508
> URL: https://issues.apache.org/jira/browse/MENFORCER-508
> Project: Maven Enforcer Plugin
> Issue Type: Improvement
> Components: requireSameVersions
> Affects Versions: 3.5.0
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Major
>
> Currently the rule
> [https://maven.apache.org/enforcer/enforcer-rules/requireSameVersions.html]
> does not support checking versions of the actual Maven modules (but only of
> contained dependencies and/or plugins). Often it is important that all
> modules of an aggregator project share a common version (in order to
> ease/allow releases). I propose to add an additional flag
> {{sameModuleVersions}} which if set to {{true}} enforces all modules built
> from the reactor root share a common version. This should also support
> [CI-friendly versions|https://maven.apache.org/maven-ci-friendly.html]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
