elharo commented on code in PR #154:
URL: https://github.com/apache/maven-site-plugin/pull/154#discussion_r1685728294
##########
src/main/java/org/apache/maven/plugins/site/deploy/AbstractDeployMojo.java:
##########
@@ -429,21 +429,21 @@ public static ProxyInfo getProxyInfo(Repository
repository, WagonManager wagonMa
String nonProxyHostPrefix = nonProxyHost.substring(0, pos);
String nonProxyHostSuffix = nonProxyHost.substring(pos + 1);
// prefix*
- if (StringUtils.isNotEmpty(nonProxyHostPrefix)
+ if ((nonProxyHostPrefix != null &&
!nonProxyHostPrefix.isEmpty())
Review Comment:
null checks aren't needed here. substring never returns null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
