[
https://issues.apache.org/jira/browse/MJAVADOC-710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865759#comment-17865759
]
Piotr Zygielo edited comment on MJAVADOC-710 at 7/14/24 9:25 AM:
-----------------------------------------------------------------
I can't remember the thing. But PR-126 was closed as included in 127, and 127
was closed without being merged.
I rebased PR-126 on current master (d3afd39f) and m-javadoc-p is still fine
with replaced/removed parameters (which I found as bad back then). There are
warnings like: {{Parameter 'proxyHost' is unknown for plugin
'maven-javadoc-plugin:3.7.1-SNAPSHOT:javadoc-no-fork (default-cli)}} at least
now, but
[https://github.com/apache/maven-javadoc-plugin/blob/3eb47c5081bf6f4158333bd378641bc9b7c9a25f/src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java#L1841-L1859]
seem to be useless.
As more than few weeks passed since PR-127 was closed, some conflicting changes
happened (in formatting/having spotless or so) thus I can't just rebase that on
master. But if someone agrees with what was reported here in first place, I
can pick changes again in new PR. Or maybe other solution could be implemented
by other party.
I'm open for discussion or for closing it should I be the only one to be
bothered with it.
was (Author: pzygielo):
I can't remember the thing. But PR-126 was closed as included in 127, and 127
was closed without being merged.
I rebased PR-126 on current master (d3afd39f) and m-javadoc-p is still fine
with replaced/removed parameters (which I found as bad back then). There are
warnings like: {{Parameter 'proxyHost' is unknown for plugin
'maven-javadoc-plugin:3.7.1-SNAPSHOT:javadoc-no-fork (default-cli)}} at least
now, but
[https://github.com/apache/maven-javadoc-plugin/blob/3eb47c5081bf6f4158333bd378641bc9b7c9a25f/src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java#L1841-L1859]
seem to be useless.
As more than few weeks passed since PR-127 was closed, some conflicting changes
happened (in formatting/having spotless or so) thus I can't just rebase that on
master. But if someone agrees with with what was reported here in first place,
I can pick changes again in new PR. Or maybe other solution could be
implemented by other party.
I'm open for discussion or for closing it should I be the only one to be
bothered with it.
> Usage of removed or replaced property does not cause the build to fail
> ----------------------------------------------------------------------
>
> Key: MJAVADOC-710
> URL: https://issues.apache.org/jira/browse/MJAVADOC-710
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Affects Versions: 3.3.2
> Reporter: Piotr Zygielo
> Priority: Major
>
> Per
> https://issues.apache.org/jira/browse/MJAVADOC-509?focusedCommentId=16581261
> {quote}Yes, additionalParam was replaced by additionalOptions in
> MJAVADOC-475(https://issues.apache.org/jira/browse/MJAVADOC-475) and the
> build will fail with 3.0.0 if this property is used.
> {quote}
> However current implementation does not do that. And as far as I've checked -
> the original implementation didn't do in 3.0.0 neither.
> This is due to {{mojo.getConfiguration()}} in
> {{AbstractJavadocMojo.verifyRemovedParameter}} having only parameters plugin
> committed for, and not all from {{<configuration>}} element. Not at the
> moment of goal execution, at least.
> This causes problems when upgrading from pre-3 plugin as {{additionalparam}}
> is silently ignored.
> I see similar case is dealt in following way:
> -
> [https://github.com/apache/maven-jar-plugin/blob/0ad60f4f2862bf896b6c0dc57ea5a6999c49b0d4/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java#L107-L115]
> -
> [https://github.com/apache/maven-deploy-plugin/blob/36a2030c8851e21cd1e0bec01c3cea4dc6055a48/src/main/java/org/apache/maven/plugins/deploy/DeployFileMojo.java#L180-L188]
> - and few others
> which is to have {{@Deprecated}} parameter, and its presence is used for
> breaking the build.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
