michael-o commented on code in PR #759:
URL: https://github.com/apache/maven-surefire/pull/759#discussion_r1670696091


##########
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java:
##########
@@ -525,6 +525,11 @@ public class IntegrationTestMojo extends 
AbstractSurefireMojo {
     @Parameter(property = "failsafe.enableProcessChecker")
     private String enableProcessChecker;
 
+    /**
+     * Properties file being used as system properties passed to the provider.
+     *
+     * @see AbstractSurefireMojo#systemPropertyVariables {@code 
systemPropertyVariables} for how the effective provider properties are 
calculated

Review Comment:
   Won't this produce two "systemPropertyVariables" literals?



##########
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java:
##########
@@ -314,16 +314,27 @@ public abstract class AbstractSurefireMojo extends 
AbstractMojo implements Suref
     /**
      * List of System properties to pass to a provider.
      *
-     * @deprecated Use systemPropertyVariables instead.
+     * @deprecated Use {@link #systemPropertyVariables} instead.
+     * @see #systemPropertyVariables {@code systemPropertyVariables} for how 
the effective provider properties are calculated

Review Comment:
   Same here



##########
maven-surefire-plugin/src/main/java/org/apache/maven/plugin/surefire/SurefirePlugin.java:
##########
@@ -502,6 +502,11 @@ public class SurefirePlugin extends AbstractSurefireMojo 
implements SurefireRepo
     @Parameter(property = "surefire.enableProcessChecker")
     private String enableProcessChecker;
 
+    /**
+     * Properties file being used as system properties passed to the provider.
+     *
+     * @see AbstractSurefireMojo#systemPropertyVariables {@code 
systemPropertyVariables} for how the effective provider properties are 
calculated

Review Comment:
   Same here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to