[
https://issues.apache.org/jira/browse/MSITE-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863830#comment-17863830
]
ASF GitHub Bot commented on MSITE-1012:
---------------------------------------
Bukama commented on code in PR #195:
URL: https://github.com/apache/maven-site-plugin/pull/195#discussion_r1668836221
##########
src/main/java/org/apache/maven/plugins/site/deploy/SiteStageDeployMojo.java:
##########
@@ -213,9 +213,9 @@ private String determineStageDeploySiteURL() throws
MojoExecutionException {
return defaultStagingSiteURL;
}
- private String stagingRepoId() {
- if (stagingRepositoryId != null) {
- return stagingRepositoryId;
+ private String determineStagingRepoId() {
Review Comment:
As you changed the wording from `repository` to `site` everywhere: I assume
this method then should be named `determineStagingSiteId`?
> Clean up notion that sites aren't deployed to repositories
> ----------------------------------------------------------
>
> Key: MSITE-1012
> URL: https://issues.apache.org/jira/browse/MSITE-1012
> Project: Maven Site Plugin
> Issue Type: Task
> Components: inheritance, multi module, site:deploy
> Affects Versions: 4.0.0-M15
> Reporter: Michael Osipov
> Assignee: Michael Osipov
> Priority: Major
> Fix For: 4.0.0, 4.0.0-M16
>
>
> As is seems with MSITE-1010 people assume that since we use the term "site
> repository" it behaves like a Maven repository in terms of structure. It does
> *not*. Let's get rid of that term and use "site" or "site deployment" only.
> No implications. With this, the parameter {{stagingRepositoryId}} in
> {{SiteStageDeployMojo}} will be ranamed to {{stagingSiteId}} to clean up
> confusion.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)