[ 
https://issues.apache.org/jira/browse/MJARSIGNER-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863618#comment-17863618
 ] 

ASF GitHub Bot commented on MJARSIGNER-76:
------------------------------------------

Marcono1234 commented on PR #20:
URL: 
https://github.com/apache/maven-jarsigner-plugin/pull/20#issuecomment-2212519982

   @elharo, regarding your comment here and also your [comment on 
JIRA](https://issues.apache.org/jira/browse/MJARSIGNER-76?focusedCommentId=17863556&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17863556):
   > This is yet more unactionable log junk for builds that already have far 
too much of it. 
   
   I don't really agree that it is "unactionable" (nor that is "junk"). As 
mentioned in the issue description on JIRA, the current output does not make it 
clear which files the plugin actually signed. Or what do you mean by 
"unactionable"? Technically all INFO messages from Maven and plugins are 
unactionable because they just inform you what Maven or the plugins are doing, 
without prompting you to change anything (unlike WARNING or ERROR).
   
   And sure, it would be great if Maven printed nearly nothing to the console 
and everything just worked. But in the cases where something does not work, or 
even where the build is successful but the result in unexpected, such output 
can be useful for troubleshooting.
   And you can customize Maven logging to only log WARNING and above.
   
   Or which cases are you thinking of where this output is not useful? Builds 
with dozens of signed files? I would just like to know why you are so strongly 
opposed to this.
   
   As suggested by @lasselindqvist above, would it be acceptable to log this at 
DEBUG level?




> Print names of processed files
> ------------------------------
>
>                 Key: MJARSIGNER-76
>                 URL: https://issues.apache.org/jira/browse/MJARSIGNER-76
>             Project: Maven Jar Signer Plugin
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>            Reporter: Marcono1234
>            Priority: Minor
>
> h2. Problem
> Currently the plugin just prints the number of processed artifacts once it is 
> done, for example:
> {quote}
> 2 archive(s) processed
> {quote}
> This has these disadvantages:
> - It is not immediately obvious if the intended file has been signed (e.g. 
> when using wildcards)
> - If the number is higher than expected, it is not obvious which additional 
> files were signed redundantly
> In both cases it is necessary to manually inspect the artifacts of the 
> project and check if they have been signed (or use {{jarsigner}} to verify 
> them).
> h2. Improvement
> By default the plugin should print the file names of the signed artifacts. 
> This information is already available in {{AbstractJarsignerMojo#execute}}, 
> but currently only {{archives.size()}} is logged.
> - Ideally each file should be logged in a separate line to be easier to read.
> - The relative file path (and not only the file name) should be logged. 
> Otherwise there might be confusion if the same file exists in multiple 
> directories, e.g. if it is copied by another plugin during the build.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to