adangel commented on code in PR #150: URL: https://github.com/apache/maven-pmd-plugin/pull/150#discussion_r1628874773
########## src/main/java/org/apache/maven/plugins/pmd/exec/PmdErrorMessageReporter.java: ########## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.plugins.pmd.exec; + +import java.util.ArrayList; +import java.util.List; + +import net.sourceforge.pmd.util.log.PmdReporter; +import org.apache.maven.reporting.MavenReportException; +import org.checkerframework.checker.nullness.qual.Nullable; +import org.slf4j.event.Level; + +class PmdErrorMessageReporter implements PmdReporter { + private final PmdReporter delegate; + private List<Throwable> errors = new ArrayList<>(); + + PmdErrorMessageReporter(PmdReporter delegate) { + this.delegate = delegate; + } + + @Override + public boolean isLoggable(Level level) { + return delegate.isLoggable(level); + } + + @Override + public void logEx(Level level, @Nullable String message, Object[] formatArgs, @Nullable Throwable error) { + if (error != null) { + if (error instanceof RuntimeException && error.getCause() instanceof MavenReportException) { + errors.add(error.getCause()); + } else { + errors.add(error); + } + } + + delegate.logEx(level, message, formatArgs, error); + } + + @Override + public int numErrors() { + return delegate.numErrors(); + } + + public void rethrowErrorsAsMavenReportException() throws MavenReportException { + if (errors.isEmpty()) { + return; + } + + final MavenReportException exception; + + Throwable firstError = errors.get(0); Review Comment: Multiple exception can potentially occur. E.g. if someone tries to run CPD on java files, that don't compile and are not valid java source - each file would produce an exception. And right, as I delegate it to the original PmdReporter, it will have been logged (through slf4j) already, when we rethrow the exception(s). The whole goal of this exercise is, that the build fails, when some exceptions occurred, that potentially mean, that not all files have been analyzed. Who reads the logs, if in the end it says "BUILD SUCCESS"? When this plugin was created, it never failed when there was any problem while executing PMD - some files where then just silently not analyzed. For the pmd:pmd goal, the parameter "skipPmdError" was introduced with the sake for compatibility defaulting to the old behavior (just ignoring any errors). The cpd:cpd goal doesn't have such an option and I don't know how this behaved earlier. But if any errors occur during analysis, IMHO the build must fail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
