[
https://issues.apache.org/jira/browse/MNG-7902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848764#comment-17848764
]
ASF GitHub Bot commented on MNG-7902:
-------------------------------------
slawekjaranowski commented on code in PR #1510:
URL: https://github.com/apache/maven/pull/1510#discussion_r1610727735
##########
maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultPluginValidationManager.java:
##########
@@ -203,7 +204,7 @@ public void reportPluginMojoValidationIssue(
mayReportInline(mavenSession.getRepositorySession(), locality, issue);
}
- private void reportSessionCollectedValidationIssues(MavenSession
mavenSession) {
+ public void reportSessionCollectedValidationIssues(MavenSession
mavenSession) {
Review Comment:
why change to `public`?
> sort plugins in validation report
> ---------------------------------
>
> Key: MNG-7902
> URL: https://issues.apache.org/jira/browse/MNG-7902
> Project: Maven
> Issue Type: Improvement
> Components: Core
> Reporter: Michael Keppler
> Priority: Minor
> Attachments: image-2023-10-07-13-33-27-762.png
>
>
> Please don't ever output the content of a Set for consumption by humans
> without sorting it first. The order is otherwise "random". Sorting (case
> insensitive) makes the same output easier to read, especially when trying to
> find one specific entry (e.g. "Did we fix plugin foo already?")
> !image-2023-10-07-13-33-27-762.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
