[
https://issues.apache.org/jira/browse/MNG-7902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848466#comment-17848466
]
ASF GitHub Bot commented on MNG-7902:
-------------------------------------
gnodet commented on code in PR #1510:
URL: https://github.com/apache/maven/pull/1510#discussion_r1609369940
##########
maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultPluginValidationManager.java:
##########
@@ -23,17 +23,7 @@
import java.nio.file.Path;
import java.nio.file.Paths;
-import java.util.Arrays;
-import java.util.Collection;
-import java.util.Collections;
-import java.util.EnumSet;
-import java.util.HashMap;
-import java.util.LinkedHashMap;
-import java.util.LinkedHashSet;
-import java.util.List;
-import java.util.Locale;
-import java.util.Map;
-import java.util.Set;
+import java.util.*;
Review Comment:
spotless and impsort plugins can't fix star -> individual imports because
that would require access to the full class path and they really only operate
on a single file.
That also mean the opposite (so I was wrong), i.e. they won't refactor
multiple imports into a single one I think. It must have been the IDE.
Which means the PR should not contain the star.
@slawekjaranowski it seems the AvoidStarImport is [no more
enforced](https://github.com/apache/maven-shared-resources/blob/maven-shared-resources-5/src/main/resources/config/maven_checks_nocodestyle.xml).
I think we removed it based on the assumption that it was handled by
spotless/impsort, but that does not seem to be the case
@yuehcw can you remove the star import ?
> sort plugins in validation report
> ---------------------------------
>
> Key: MNG-7902
> URL: https://issues.apache.org/jira/browse/MNG-7902
> Project: Maven
> Issue Type: Improvement
> Components: Core
> Reporter: Michael Keppler
> Priority: Minor
> Attachments: image-2023-10-07-13-33-27-762.png
>
>
> Please don't ever output the content of a Set for consumption by humans
> without sorting it first. The order is otherwise "random". Sorting (case
> insensitive) makes the same output easier to read, especially when trying to
> find one specific entry (e.g. "Did we fix plugin foo already?")
> !image-2023-10-07-13-33-27-762.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
