Re: [PR] [MPLUGIN-521] Nested types not properly extracted cause exception whi… [maven-plugin-tools]

[via GitHub]

michael-o commented on code in PR #281:
URL: 
https://github.com/apache/maven-plugin-tools/pull/281#discussion_r1587606761


##########
maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginDescriptorFilesGenerator.java:
##########
@@ -637,10 +637,10 @@ static URI getJavadocUrlForType(JavadocLinkGenerator 
javadocLinkGenerator, Strin
                     .split(",\\s*");
             switch (parameterTypes.length) {
                 case 1: // if only one parameter type, assume collection, 
first parameter type is most interesting
-                    binaryName = parameterTypes[0];
+                    binaryName = 
extractbinaryNameForJavadoc(parameterTypes[0]);
                     break;
                 case 2: // if two parameter types assume map, second parameter 
type is most interesting
-                    binaryName = parameterTypes[1];
+                    binaryName = 
extractbinaryNameForJavadoc(parameterTypes[1]);

Review Comment:
   ```suggestion
                       binaryName = 
extractBinaryNameForJavadoc(parameterTypes[1]);
   ```



##########
maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginDescriptorFilesGenerator.java:
##########
@@ -637,10 +637,10 @@ static URI getJavadocUrlForType(JavadocLinkGenerator 
javadocLinkGenerator, Strin
                     .split(",\\s*");
             switch (parameterTypes.length) {
                 case 1: // if only one parameter type, assume collection, 
first parameter type is most interesting
-                    binaryName = parameterTypes[0];
+                    binaryName = 
extractbinaryNameForJavadoc(parameterTypes[0]);

Review Comment:
   ```suggestion
                       binaryName = 
extractBinaryNameForJavadoc(parameterTypes[0]);
   ```



##########
maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginDescriptorFilesGenerator.java:
##########
@@ -649,7 +649,11 @@ static URI getJavadocUrlForType(JavadocLinkGenerator 
javadocLinkGenerator, Strin
         } else {
             binaryName = type;
         }
-        return javadocLinkGenerator.createLink(binaryName);
+        return binaryName;
+    }
+
+    static URI getJavadocUrlForType(JavadocLinkGenerator javadocLinkGenerator, 
String type) {
+        return 
javadocLinkGenerator.createLink(extractbinaryNameForJavadoc(type));

Review Comment:
   ```suggestion
           return 
javadocLinkGenerator.createLink(extractBinaryNameForJavadoc(type));
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org