[
https://issues.apache.org/jira/browse/MSKINS-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842581#comment-17842581
]
ASF GitHub Bot commented on MSKINS-245:
---------------------------------------
michael-o commented on code in PR #58:
URL: https://github.com/apache/maven-fluido-skin/pull/58#discussion_r1586012833
##########
src/main/resources/META-INF/maven/site.vm:
##########
@@ -239,7 +239,7 @@
#* *##set( $sourceStyle = "prettyprint" )
#* *##end
##
-#* *#$bodyContent.replaceAll( '<div class="verbatim
source">(\r?\n)?<pre>', '<div class="verbatim source"><pre class="' +
$sourceStyle + '">' ).replaceAll( 'class="bodyTable"', 'class="table
table-striped"' ).replaceAll( 'class="bodyTable bodyTableBorder"',
'class="table table-bordered table-striped"' )
+#* *#$bodyContent.replaceAll( '<pre><code>', '<pre class="' +
$sourceStyle + '"><code>' ).replaceAll( 'class="bodyTable"', 'class="table
table-striped"' ).replaceAll( 'class="bodyTable bodyTableBorder"',
'class="table table-bordered table-striped"' )
Review Comment:
Since we don't need regex anymore, we can resort to just `replace()` here.
> Maven Site 4 will break code highlight of site generated by Markdown
> --------------------------------------------------------------------
>
> Key: MSKINS-245
> URL: https://issues.apache.org/jira/browse/MSKINS-245
> Project: Maven Skins
> Issue Type: Bug
> Components: Fluido Skin
> Reporter: Xavi Lee
> Assignee: Konrad Windszus
> Priority: Major
> Fix For: fluido-2.0.0-M9, fluido-2.0.0
>
> Attachments: maven-site-3.png, maven-site-4.png, test-v3.html,
> test-v4.html
>
>
> repro repo https://github.com/awxiaoxian2020/code-render-bug
> master branch is Maven Site 3 with Fluido skin 1
> v4 branch is Maven Site 4 with Fluido skin 2.
> Open their respective `target/site/test.html` files in local to see the
> rendered result.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
