cstamas commented on code in PR #469:
URL: https://github.com/apache/maven-resolver/pull/469#discussion_r1566975286
##########
maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/HttpTransporter.java:
##########
@@ -691,8 +690,7 @@ public void handle(CloseableHttpResponse response) throws
IOException, TransferC
if (lastModifiedHeader != null) {
Date lastModified =
DateUtils.parseDate(lastModifiedHeader.getValue());
if (lastModified != null) {
- Files.setLastModifiedTime(
- task.getDataFile().toPath(),
FileTime.fromMillis(lastModified.getTime()));
+
task.getDataFile().setLastModified(lastModified.getTime());
Review Comment:
@rmannibucau As I told to @michael-o , I find this proposal futile, and here
is why: user @Jurrie spotted this problem ONLY HERE as this was the only one
spot using method that throws (`Files.setLastModified`). If you look at master
PR https://github.com/apache/maven-resolver/pull/468 it will show you all the
places where time mtime is set (as master was ported from `File` to `Path`). So
all those place will not log anything and are "forgiving" when they try but
fail to set mtime, and hence, logging it only here makes no sense IMHO. If you
want, you can make a PR for 1.9.x that sweep changes all `File.setLastModified`
usages and logs something at TRACE, but I find it useless change (as it never
logged that so far).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
