rmannibucau commented on code in PR #469:
URL: https://github.com/apache/maven-resolver/pull/469#discussion_r1566964022
##########
maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/HttpTransporter.java:
##########
@@ -691,8 +690,7 @@ public void handle(CloseableHttpResponse response) throws
IOException, TransferC
if (lastModifiedHeader != null) {
Date lastModified =
DateUtils.parseDate(lastModifiedHeader.getValue());
if (lastModified != null) {
- Files.setLastModifiedTime(
- task.getDataFile().toPath(),
FileTime.fromMillis(lastModified.getTime()));
+
task.getDataFile().setLastModified(lastModified.getTime());
Review Comment:
While using path or file is something I don't care debating I think tracing
there was an error and therefore the lastmodified value is wrong is valuable in
the log so please log it (`if (!setlastmodified) log.trace()`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
