[ 
https://issues.apache.org/jira/browse/MSITE-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836104#comment-17836104
 ] 

ASF GitHub Bot commented on MSITE-723:
--------------------------------------

michael-o opened a new pull request, #179:
URL: https://github.com/apache/maven-site-plugin/pull/179

   We truly generate the file now instead of copying it.
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MSITE) filed 
          for the change (usually before you start working on it).  Trivial 
changes like typos do not 
          require a JIRA issue.  Your pull request should address just this 
issue, without 
          pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line 
and body.
    - [ ] Format the pull request title like `[MSITE-XXX] - Fixes bug in 
ApproximateQuantiles`,
          where you replace `MSITE-XXX` with the appropriate JIRA issue. Best 
practice
          is to use the JIRA issue title in the pull request title and in the 
first line of the 
          commit message.
    - [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
    - [ ] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
          be performed on your pull request automatically.
    - [ ] You have run the integration tests successfully (`mvn -Prun-its clean 
verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [ ] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   




> "About" report generated even though index.apt is available in 
> "generated-site"
> -------------------------------------------------------------------------------
>
>                 Key: MSITE-723
>                 URL: https://issues.apache.org/jira/browse/MSITE-723
>             Project: Maven Site Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.0, 3.0, 3.4
>            Reporter: Andrius Velykis
>            Assignee: Herve Boutemy
>            Priority: Major
>             Fix For: 3.5
>
>         Attachments: mvn-site-index.zip
>
>
> Normally, if there is an apt/index.apt file in the /src/site directory, About 
> report is not generated, and the following message is displayed: Skipped 
> "About" report, file "index.html" already exists for the English version.
> Expecting the same behaviour, I have a situation, where the index.apt file is 
> generated automatically (e.g. copied from somewhere) during `pre-site` phase. 
> maven-site-plugin allows specifying an additional `generatedSiteDirectory` 
> parameter for these files (see 
> http://maven.apache.org/plugins/maven-site-plugin/site-mojo.html).
> However, in this case, the "About" report is generated and overrides the 
> copied file from `generatedSiteDirectory` parameter.
> I would expect the "About" report to be not generated, if index.apt is 
> available in the `generatedSiteDirectory`.
> I have attached a sample project, which uses `antrun` to copy a file to 
> /target/generated-site/apt/index.apt. When you run `mvn site`, it will still 
> display the default "About" page. As an example that `generatedSiteDirectory` 
> works, I also copy the same file to index-copy.apt and an index-copy.html is 
> generated correctly.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to