[
https://issues.apache.org/jira/browse/SCM-939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834922#comment-17834922
]
ASF GitHub Bot commented on SCM-939:
------------------------------------
michael-o commented on PR #150:
URL: https://github.com/apache/maven-scm/pull/150#issuecomment-2042791182
> > @nielsbasjes I did a few updates...
>
> Yes of course. Please change/copy/do what you think is best with my
partial contribution. Feel free to take it over completely because I do not
have enough understanding of several key components to finish it.
For me, this looks decent now, but I want to make a few more checks. @kwin
Do you want to review?
> Assume SCM is present
> ---------------------
>
> Key: SCM-939
> URL: https://issues.apache.org/jira/browse/SCM-939
> Project: Maven SCM
> Issue Type: Bug
> Reporter: Elliotte Rusty Harold
> Priority: Minor
>
> We have a lot of tests that do something like this:
>
> if ( !ScmTestCase.isSystemCmd( SvnScmTestUtils.SVN_COMMAND_LINE ) )
> {
> ScmTestCase.printSystemCmdUnavail( SvnScmTestUtils.SVN_COMMAND_LINE,
> getName() );
> return;
> }
>
> We should instead use org.*junit*.*Assume* here so these are marked as
> skipped rather than passed.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
