[ 
http://jira.codehaus.org/browse/MRM-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_103435
 ] 

Maria Odea Ching commented on MRM-329:
--------------------------------------

Good work on the reports Teody!

I've applied the patch in my local machine to try it out and here are my 
comments:
1. For the number links, I think it would be better to have it that way so that 
it's easier for the user to browse through the report.
2. I also agree on giving the user the functionality to choose the resulting 
number of rows per page.
3. It would be nice if there is a default message that tells the user that 
there are no errors to be reported when the user clicks 'Reports' in the 
navigation menu, instead of just a blank page.
4. Maybe the report should be renamed to something else other than 'All 
Problematic Artifacts' (hehe.. I felt like these artifacts were depressed)

I'm not sure about #4 and #5, I think you should ask Joakim about it.
For #6, you could try generating a jrxml file using iReport and see how the 
<staticText> works ;)


> The Reports link gives an HTTP 500
> ----------------------------------
>
>                 Key: MRM-329
>                 URL: http://jira.codehaus.org/browse/MRM-329
>             Project: Archiva
>          Issue Type: Bug
>          Components: reporting
>    Affects Versions: 1.0-alpha-1
>            Reporter: Napoleon Esmundo C. Ramirez
>            Assignee: Joakim Erdfelt
>            Priority: Blocker
>             Fix For: 1.0-beta-1
>
>         Attachments: MRM-329-archiva-database-20070725.patch, 
> MRM-329-archiva-model-20070727.patch, MRM-329-archiva-webapp-20070725.patch
>
>
> Clicking the Reports link in the side navigation menu displays the following 
> (edited/snipped stacktrace): 
> HTTP ERROR: 500
> RequestURI=/admin/reports.action
> Caused by: javax.el.PropertyNotFoundException: The class 
> 'org.apache.maven.archiva.reporting.artifact.OldArtifactReport' does not have 
> the property 'groupId'.
> at javax.el.BeanELResolver.getBeanProperty(BeanELResolver.java:574)
> at javax.el.BeanELResolver.getValue(BeanELResolver.java:280)
> at javax.el.CompositeELResolver.getValue(CompositeELResolver.java:143)
> at com.sun.el.parser.AstValue.getValue(AstValue.java:118)
> at com.sun.el.ValueExpressionImpl.getValue(ValueExpressionImpl.java:192)
> at 
> org.apache.jasper.runtime.PageContextImpl.evaluateExpression(PageContextImpl.java:974)
> at 
> org.apache.jsp.WEB_002dINF.jsp.reports.reports_jsp._jspx_meth_c_forEach_0(org.apache.jsp.WEB_002dINF.jsp.reports.reports_jsp:143)
> at 
> org.apache.jsp.WEB_002dINF.jsp.reports.reports_jsp._jspService(org.apache.jsp.WEB_002dINF.jsp.reports.reports_jsp:85)
> at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:111)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
> at 
> org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:373)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to